Skip to content

Run test suite with dev version of bokeh#6715

Open
jrbourbeau wants to merge 6 commits intodask:mainfrom
jrbourbeau:test-dev-bokeh
Open

Run test suite with dev version of bokeh#6715
jrbourbeau wants to merge 6 commits intodask:mainfrom
jrbourbeau:test-dev-bokeh

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

xref #6707

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 54m 2s ⏱️ + 30m 44s
  3 086 tests ±0    2 988 ✔️  - 12    85 💤 +1  13 +11 
22 834 runs  ±0  21 758 ✔️  - 89  985 💤 ±0  91 +89 

For more details on these failures, see this check.

Results for commit 10767d6. ± Comparison against base commit bfc5cfe.

♻️ This comment has been updated with latest results.

@jrbourbeau
Copy link
Copy Markdown
Member Author

@bryevdv it looks like these are the following things that are popping up in CI when using the nightly bokeh conda package:

AttributeError: module 'bokeh.plotting' has no attribute 'Figure'
TypeError: linear_cmap() got an unexpected keyword argument 'field_name'
 bokeh.util.warnings.BokehDeprecationWarning: on_click(handler) was deprecated in Bokeh 3.0.0 and will be removed, use on_event("button_click", handler) instead.
bokeh.util.warnings.BokehDeprecationWarning: CDSView.filters was deprecated in bokeh 3.0. Use CDSView.filter instead.

@bryevdv
Copy link
Copy Markdown
Contributor

bryevdv commented Jul 12, 2022

AttributeError: module 'bokeh.plotting' has no attribute 'Figure'

Redundant and removed, everything should use figure (lower-f) but I will see if we can't add a module getter to afford a deprecated Figure back

TypeError: linear_cmap() got an unexpected keyword argument 'field_name'

This was evidently changed to just field but I am not sure for what good reason, I will open an issue to propose restoring it as before

The deprecations will continue to work, but it would be good to update them any time after Dask sets Bokeh 3.0 as the min version.

@bryevdv
Copy link
Copy Markdown
Contributor

bryevdv commented Jul 12, 2022

@jrbourbeau can you try to confirm that these errors are not just test-only issues, and that they affect real codepaths?

@bryevdv
Copy link
Copy Markdown
Contributor

bryevdv commented Jul 14, 2022

@jrbourbeau I am submitting a PR to revert the field_name rename. I think the Figure issue is test-only:

143:    assert isinstance(figure, bokeh.plotting.Figure)
158:    assert isinstance(ts.figure, bokeh.plotting.Figure)

So I think that can be handled on this end.

@jrbourbeau jrbourbeau requested a review from fjetter as a code owner January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants