Allow all hosts in jupyter-server-proxy#6966
Conversation
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 48m 0s ⏱️ + 5m 57s For more details on these failures, see this check. Results for commit 64410d9. ± Comparison against base commit bfc5cfe. |
jacobtomlinson
left a comment
There was a problem hiding this comment.
I am apprehensive to just set this to True and allow all proxying. This feature of jupyter-server-proxy is intended to avoid folks from using the proxy to access services they shouldn't.
Ideally we should just be adding the worker IPs to the allowlist.
cc @yuvipanda who may have opinions here
Allows the dashboard for remote workers on the bokeh info page to function by modifying
host_allowlist.This solves the error
Host 'xxx' is not allowed. See https://jupyter-server-proxy.readthedocs.io/en/latest/arbitrary-ports-hosts.html for info.pre-commit run --all-files