Avoid signaling outside main thread when starting jupyter server#7033
Avoid signaling outside main thread when starting jupyter server#7033
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 26m 26s ⏱️ + 13m 13s For more details on these failures, see this check. Results for commit 8439f35. ± Comparison against base commit 1fd07f0. ♻️ This comment has been updated with latest results. |
|
You took me literally enough. |
|
Huh I would have thought so too but evidently not... but regardless yeah I agree that seems like the right thing to do |
|
@mrocklin any thoughts on this? obviously kind of a niche use case within a niche use case but seems pretty safe to me...? |
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @bnaul! Would you mind adding some kind of test for this?
It sounds like @Carreau is happy with the changes here. @ian-r-rose do you have any thoughts?
|
Seems reasonable to me -- I'd like an explanatory comment, but otherwise LGTM |
|
Thanks @jrbourbeau and @ian-r-rose, I added a simple test and comment |
Closes #6886
@mrocklin dunno if I was taking @Carreau too literally here but this does resolve the issue (i.e. the example from the issue now succeeds). Not sure if it's bad form to be actually overriding these class methods, maybe we want to subclass or something?