Skip to content

Clean up deprecations in register_plugin#9225

Open
crusaderky wants to merge 1 commit intodask:mainfrom
crusaderky:registerplugin-deprecations
Open

Clean up deprecations in register_plugin#9225
crusaderky wants to merge 1 commit intodask:mainfrom
crusaderky:registerplugin-deprecations

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    30 files  ±  0      30 suites  ±0   11h 5m 7s ⏱️ + 2m 10s
 4 103 tests  -  12   3 994 ✅  -  13    104 💤 ±0  5 ❌ +1 
59 575 runs   - 180  57 129 ✅  - 182  2 440 💤 ±0  6 ❌ +2 

For more details on these failures, see this check.

Results for commit 0fd7326. ± Comparison against base commit d9c0010.

This pull request removes 12 tests.
distributed.diagnostics.tests.test_nanny_plugin ‑ test_duck_typed_register_nanny_plugin_is_deprecated
distributed.diagnostics.tests.test_nanny_plugin ‑ test_register_plugin_with_idempotent_keyword_is_deprecated
distributed.diagnostics.tests.test_nanny_plugin ‑ test_register_worker_plugin_is_deprecated
distributed.diagnostics.tests.test_nanny_plugin ‑ test_register_worker_plugin_typing_over_nanny_keyword
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_register_plugin_with_idempotent_keyword_is_deprecated
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_register_scheduler_plugin_deprecated
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_scheduler_plugin_in_register_worker_plugin_overrides
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_scheduler_plugin_in_register_worker_plugin_overrides_nanny
distributed.diagnostics.tests.test_worker_plugin ‑ test_duck_typed_register_worker_plugin_is_deprecated
distributed.diagnostics.tests.test_worker_plugin ‑ test_register_plugin_with_idempotent_keyword_is_deprecated
…

♻️ This comment has been updated with latest results.

@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Apr 28, 2026

All failures are unrelated. Ready for review.

@crusaderky crusaderky added the deprecation Something is being removed label Apr 29, 2026
@crusaderky crusaderky marked this pull request as draft April 29, 2026 15:19
@crusaderky crusaderky force-pushed the registerplugin-deprecations branch from 183f500 to 1a978c3 Compare April 29, 2026 15:44
@crusaderky crusaderky marked this pull request as ready for review April 29, 2026 22:58
@crusaderky crusaderky force-pushed the registerplugin-deprecations branch from 1a978c3 to f57a9f1 Compare April 29, 2026 23:21
@crusaderky crusaderky marked this pull request as draft April 29, 2026 23:22
@crusaderky crusaderky force-pushed the registerplugin-deprecations branch from f57a9f1 to 0fd7326 Compare April 30, 2026 09:54
@crusaderky crusaderky marked this pull request as ready for review April 30, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Something is being removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant