Skip to content

Clean up deprecated Lock client parameter#9237

Merged
crusaderky merged 3 commits intodask:mainfrom
crusaderky:deprecated_lock_client
May 3, 2026
Merged

Clean up deprecated Lock client parameter#9237
crusaderky merged 3 commits intodask:mainfrom
crusaderky:deprecated_lock_client

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

No description provided.

@crusaderky crusaderky added the deprecation Something is being removed label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files   -     1      29 suites   - 1   10h 38m 21s ⏱️ - 31m 34s
 4 111 tests ±    0   4 002 ✅  -     2    105 💤 ± 0  4 ❌ +2 
57 108 runs   - 2 674  54 683 ✅  - 2 618  2 421 💤  - 58  4 ❌ +2 

For more details on these failures, see this check.

Results for commit e4ea330. ± Comparison against base commit 4be9043.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky marked this pull request as ready for review April 30, 2026 10:16
@crusaderky crusaderky requested a review from fjetter as a code owner April 30, 2026 10:16
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a new merge conflict, but otherwise LGTM @crusaderky

(client has not only been deprecated, but has been dead code for a while)

@crusaderky crusaderky merged commit b9352a1 into dask:main May 3, 2026
29 of 37 checks passed
@crusaderky crusaderky deleted the deprecated_lock_client branch May 3, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Something is being removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants