Skip to content

Type annotations for client.Future#9255

Merged
crusaderky merged 4 commits into
dask:mainfrom
crusaderky:future-typing
May 3, 2026
Merged

Type annotations for client.Future#9255
crusaderky merged 4 commits into
dask:mainfrom
crusaderky:future-typing

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

Supersedes #9158

@crusaderky crusaderky added the typing Type hinting label May 3, 2026
@crusaderky crusaderky requested a review from fjetter as a code owner May 3, 2026 16:02
Comment thread distributed/client.py
Comment on lines -169 to -171
def __reduce__(self):
return self.__class__, (self.key, self.reason, self.msg)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relic of Python 2.7

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's a relic that tblib carried over until the extremely recent release 3.2.1. It has to stay for a couple more years.

@crusaderky crusaderky marked this pull request as draft May 3, 2026 16:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files   -     1      29 suites   - 1   10h 46m 1s ⏱️ - 6m 35s
 4 111 tests ±    0   4 003 ✅ +    2    105 💤 ±  0  3 ❌  - 2 
57 250 runs   - 2 532  54 904 ✅  - 2 394  2 343 💤  - 136  3 ❌  - 2 

For more details on these failures, see this check.

Results for commit a612f32. ± Comparison against base commit b9352a1.

@crusaderky crusaderky marked this pull request as ready for review May 3, 2026 22:26
@crusaderky crusaderky merged commit 4daa5aa into dask:main May 3, 2026
30 of 37 checks passed
@crusaderky crusaderky deleted the future-typing branch May 3, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Type hinting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants