Skip to content

Add explicit check for name not None#9265

Merged
crusaderky merged 1 commit into
dask:mainfrom
maneesh29s:fix-prefix-executor-name
May 19, 2026
Merged

Add explicit check for name not None#9265
crusaderky merged 1 commit into
dask:mainfrom
maneesh29s:fix-prefix-executor-name

Conversation

@maneesh29s
Copy link
Copy Markdown
Contributor

  • Tests added / passed
  • Passes pre-commit run --all-files

With #9120 , I had added dask worker's name as a prefix into the default executor.

The LocalCluster by default names the workers as numbers, starting from 0.
Assuming the LocalCluster spawns 3 workers, 1 thread each, the names of the dask workers are allocated like this:

Dask-Default-Threads-2770614-0
1-Dask-Default-Threads-2770626-0
2-Dask-Default-Threads-2770614-0

The prefix 0- is missing from the first worker's name.

This PR fixes this, explictly checking for name is not None.

@maneesh29s maneesh29s requested a review from fjetter as a code owner May 16, 2026 09:25
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    31 files  ±0      31 suites  ±0   11h 10m 2s ⏱️ - 7m 26s
 4 121 tests ±0   4 013 ✅  - 1    105 💤 ±0  3 ❌ +1 
59 815 runs  ±0  57 324 ✅  - 1  2 488 💤 ±0  3 ❌ +1 

For more details on these failures, see this check.

Results for commit ead8f87. ± Comparison against base commit cf508b9.

@crusaderky crusaderky merged commit 1ebbbf6 into dask:main May 19, 2026
34 of 38 checks passed
@crusaderky
Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants