Skip to content

Fix flaky test_steal_twice and test_steal_when_more_tasks#9288

Merged
crusaderky merged 4 commits into
dask:mainfrom
crusaderky:steal-twice
Jun 5, 2026
Merged

Fix flaky test_steal_twice and test_steal_when_more_tasks#9288
crusaderky merged 4 commits into
dask:mainfrom
crusaderky:steal-twice

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Jun 5, 2026

  • Closes test_steal_twice flaky #4957
  • test_steal_twice was almost always failing on high-CPU-count desktops due to unbound number of threads-per-worker
  • Change the tests to be meaningful when scheduler-side queueing is on
  • Tweak slow marker for the module

@crusaderky crusaderky requested a review from fjetter as a code owner June 5, 2026 13:00
@crusaderky crusaderky added flaky test Intermittent failures on CI. tests Unit tests and/or continuous integration stealing labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    40 files  ±0      40 suites  ±0   14h 39m 31s ⏱️ + 13m 43s
 4 152 tests ±0   3 972 ✅ +1    178 💤 ±0  2 ❌  - 1 
80 800 runs  +1  76 560 ✅ +1  4 238 💤 +2  2 ❌  - 2 

For more details on these failures, see this check.

Results for commit 597f6b2. ± Comparison against base commit daff1c6.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
distributed.tests.test_steal ‑ test_steal_when_more_tasks
distributed.tests.test_steal ‑ test_steal_large_dependency

♻️ This comment has been updated with latest results.

@crusaderky crusaderky changed the title Fix flaky test_steal_twice Fix flaky test_steal_twice and steal_when_more_tasks Jun 5, 2026
@crusaderky crusaderky changed the title Fix flaky test_steal_twice and steal_when_more_tasks Fix flaky test_steal_twice and test_steal_when_more_tasks Jun 5, 2026
@crusaderky crusaderky merged commit 19eb680 into dask:main Jun 5, 2026
46 of 49 checks passed
@crusaderky crusaderky deleted the steal-twice branch June 5, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky test Intermittent failures on CI. stealing tests Unit tests and/or continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_steal_twice flaky

1 participant