Fix flaky test_chaos_rechunk#9317
Draft
crusaderky wants to merge 2 commits into
Draft
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 19 files - 21 19 suites - 21 7h 8m 50s ⏱️ - 7h 6m 35s Results for commit b1bef38. ± Comparison against base commit 2d43f7f. This pull request removes 4155 and adds 100 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
test_chaos_rechunk failed frequently on slow CI hosts with a Nanny stuck in Status.closing at teardown. Root cause: WorkerProcess.kill waits timeout*0.8 for graceful shutdown, then SIGKILLs the worker but joins it with only whatever remains of the original budget (~1s or less), which on an overloaded machine is not enough even for a SIGKILLed process to be reaped. The resulting asyncio.TimeoutError aborted Nanny.close midway, leaving the nanny in Status.closing forever and deadlocking any further close() call on self.finished(). - WorkerProcess.kill: join the killed process with a fresh timeout instead of the leftovers of the graceful-shutdown budget - Nanny.close: always reach a terminal status and complete Server.close, even if killing the worker process fails - test_chaos_rechunk: raise gen_cluster timeout; on loaded CI hosts cluster startup alone can eat most of the 30s default while the test body by design runs for 10+ seconds Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test frequently hangs, e.g. https://github.com/dask/distributed/actions/runs/28594679995/job/84786875121?pr=9315
WIP unreviewed clanker output; please disregard for now