Add code linting and style check#35
Merged
Merged
Conversation
Member
Author
|
I forgot |
Member
|
Probably also good to merge all other contributor PRs first lest they have to deal with conflicts. |
Member
Author
|
Yeah, totally agree. This PR can wait |
Member
|
Should we try this again? Seems like PRs that can easily be merged have been. |
Member
Author
|
Thanks for the reminder @jakirkham : ) I've merged |
jakirkham
approved these changes
Feb 25, 2020
Member
Author
|
Planning to merge this later today is no further comments |
Closed
Member
|
Thanks @jrbourbeau! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
flake8andblackchecks for linting and code style