Conversation
|
Nice, thanks for the detailed changelog report. It's super important to document how things are changing, good work! |
| printSwarm() | ||
| }) | ||
|
|
||
| dat.on('download-finished', function () { |
There was a problem hiding this comment.
this is a great interface
|
|
||
| function printStats (data) { | ||
| var stats = dat.stats | ||
| var files = stats.filesTotal |
There was a problem hiding this comment.
what items are on .stats and which are on .appendStats and which aren't on either?
There was a problem hiding this comment.
@Karissa they overlap and could definitely use some improvement/more thought. One issue I keep running into is showing files vs "items" (files + dirs), since hyperdrive uses the combined total for it's count (archive.metadata.blocks).
.appendStats is files, dirs, and bytes calculated on sharing start. .stats is always the current archive stats, which gets updated as files are appended (initially and live).
stats = {
filesTotal: 0,
bytesTotal: 0,
bytesUp: 0,
bytesDown: 0,
rateUp: speedometer(),
rateDown: speedometer()
}
appendStats = {
files: 0,
bytes: 0,
dirs: 0
}
There was a problem hiding this comment.
I'm happy with this! We could just document these values in the README (if we want, even though it's not a public API) and ship it! :)
|
lgtm |
CLI Goodness! https://www.youtube.com/watch?v=fxKjSyCoqO4
Fixed
Changed
Removed
Added