exit if the user has requested a specific port#954
exit if the user has requested a specific port#954joehand merged 3 commits intodat-ecosystem:masterfrom
Conversation
|
I tried to work out how to use the lib/exit.js code, but couldn't figure out a way that worked. |
SvenDowideit
force-pushed
the
error-out-on-sepecifed-port
branch
from
d07902f to
a02ca0f
Compare
bin/cli.js
Outdated
| { name: 'dir', abbr: 'd', help: 'set the directory for Dat' }, | ||
| { name: 'logspeed', default: 400 }, | ||
| { name: 'port', default: 3282, help: 'port to use for connections' }, | ||
| { name: 'port', default: 0, help: 'port to use for connections (tries 3282 by default)' }, |
There was a problem hiding this comment.
I think we'd be better removing this default. Otherwise dat-node won't try 3282 first.
There was a problem hiding this comment.
Oh no it'll try 3828 first, nm. But still not sure we need this, just confuses things =).
Cool, I can take a look at adding that. |
|
Can you check out these syntax changes |
Signed-off-by: Sven Dowideit <sven.dowideit@csiro.au>
SvenDowideit
force-pushed
the
error-out-on-sepecifed-port
branch
from
a02ca0f to
0eaa0d5
Compare
|
@joehand nice! thanks for the syntax pointer. is there a test exception that can be configured for |
ya not sure what was going on there. Made it one-liner to avoid indent error. |
2 participants
Signed-off-by: Sven Dowideit sven.dowideit@csiro.au
for #945
to go with dat-ecosystem-archive/dat-node#192