Merged
Conversation
ubuntu-latest is now Ubuntu 24.04 which renamed libasound2 → libasound2t64, breaking playwright --with-deps.
Galata's built-in API handles kernel selection and waits for the notebook to be ready, avoiding the page-closed race condition.
- playwright.config.js: replace 'jlpm start' with direct 'jupyter lab' call so CI doesn't depend on jlpm being in PATH when playwright spawns the webserver process - ci.yml: use 'pip install .' (not editable) for more reliable labextension registration in CI - ci.yml: add verification step to confirm extension is installed before running Playwright tests
Galata's page fixture was polling isTabActive('Launcher') for the
full 60s timeout before Playwright killed the page. Root cause: the
fixture reset logic never completed because the Launcher tab state
check hung in CI.
New approach:
- Import from @playwright/test (not @jupyterlab/galata) so Galata's
fixture setup/teardown is never invoked
- Create notebooks via POST /api/contents (no auth in test config)
then navigate directly to /lab/tree/<path>
- playwright.config.js: drop Galata baseConfig spread, use
defineConfig directly with explicit timeout/baseURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.