BUG: torch: work around torch.round not supporting complex inputs#408
Merged
ev-br merged 1 commit intodata-apis:mainfrom Mar 17, 2026
Merged
BUG: torch: work around torch.round not supporting complex inputs#408ev-br merged 1 commit intodata-apis:mainfrom
ev-br merged 1 commit intodata-apis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a PyTorch-backend compatibility shim so array_api_compat.torch.round works on complex tensors (matching array-api-tests expectations), and removes the corresponding expected-failure entry.
Changes:
- Add a
round()wrapper inarray_api_compat/torch/_aliases.pythat rounds complex inputs by rounding real/imag parts separately. - Export the new alias via
_aliases.__all__so it overridestorch.roundin the cloned namespace. - Remove
test_roundfromtorch-xfails.txtnow that complex rounding is supported.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
array_api_compat/torch/_aliases.py |
Introduces and exports a complex-safe round() wrapper for the torch backend. |
torch-xfails.txt |
Drops the xfail for test_round because the torch backend now supports complex rounding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ev-br
force-pushed
the
torch_round
branch
2 times, most recently
from
349cde4 to
d63541d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes gh-407