ENH: testing: make assertion functions public#753
Conversation
0488a80 to
17feaf5
Compare
17feaf5 to
65512cb
Compare
|
@ev-br @mdhaber @paddyroddy could I perhaps interest anyone in running |
assert_close rtol and atol parametersDocs are unclear, both params say only "Relative tolerance" / "Absolute tolerance" with no explanation of how they combine in the comparison. Since these are core to the function, additional details in the NOTES section or doc-string would be helpful. rtol default valueThe Notes section mentions sqrt(eps) as the default rtol basis, but doesn't explain why. That came from SciPy PR #20625 (scipy/scipy#20625) and a Scientific Python Discourse thread about float32 vs float64 strictness. The rationale (float32 tolerance ~1e-3 vs float64 ~6e-8) is not obvious and worth a sentence in the Notes. xp paramAt first glance this name is perplexing, there's a good explanation on the first page of the docs. A link to the full explanation may be helpful, but its easy enough to dig up. |
1e7afd8 to
b43e705
Compare
b43e705 to
6bd7956
Compare
|
gonna click this in so that feedback on the new docs is easier once they are deployed. The API is still subject to change until the next release. But this will at least unblock work on gh-755 |
Towards gh-17.