Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Hyperkid123
force-pushed
the
migrate-common-package-typescript
branch
from
a3fdefb to
d6650bc
Compare
Hyperkid123
force-pushed
the
migrate-common-package-typescript
branch
from
d6650bc to
feb4e4c
Compare
Hyperkid123
force-pushed
the
migrate-common-package-typescript
branch
from
88dcbc2 to
99ed0d1
Compare
Hyperkid123
force-pushed
the
migrate-common-package-typescript
branch
from
99ed0d1 to
2c0d87e
Compare
karelhala
approved these changes
Feb 4, 2026
Collaborator
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Looking good, just one question.
| - name: Run build on affected projects | ||
| run: npx nx affected --target=build --parallel=3 | ||
| - name: Run build on projects | ||
| run: npx nx run-many --target=build --parallel=3 |
Collaborator
There was a problem hiding this comment.
Do we want to build all packages on a PR or just the ones affected ones?
Member
Author
There was a problem hiding this comment.
Yes. You may miss some of TS issues. The projects are not properly wired yet so we need to build all until the migration is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes