chore: bump dev data-fair image to v6, always-serve SPA#99
Merged
Conversation
7a9f6db to
613f374
Compare
613f374 to
70cb851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small dev/test infra changes, grouped together.
What changed
docker-compose.yml: devdata-fairimage5 → 6(aligns the dev upstream with the v6 registry integration already on master).api/src/app.ts: the SPA middleware now mounts in all environments (theNODE_ENV !== 'development'guard was removed). Beyond servingui/dist, this middleware also serves the runtime ui-config that the SPA fetches at startup — so it is required even in dev, where Vite (through nginx) serves the UI assets but not that config.Why
Run the dev stack against data-fair v6; serve the runtime ui-config from the API in dev too (Vite serving the UI assets isn't enough).
Regression risks
api/src/app.ts: the SPA middleware (incl. the vjsf CSP directives and the staticui/distfallback) now also mounts in dev. UI routes are still handled by Vite/nginx ahead of the API, so the static fallback is effectively inert in dev; the meaningful effect is that the ui-config is now served. Worth a sanity check that the dev request flow is otherwise unchanged.data-fair:6is a major bump of the dev upstream (dev/test only); registry/plugin integration assumptions may differ from v5.Two changes from earlier revisions of this branch were dropped: the
package-lock.jsonchurn (nopackage.jsonchange → brokenpm ci), and persisting registry tarballs to a./data/registryhost bind mount (Docker created./dataas root, breaking the dev API'sdata/developmentmkdir and failing the api tests; the registry runs as uid 1000, so a host bind mount can't be written without an init/chown step).