CDAP-17472 Make consumer id optional for mysql plugin.#122
Merged
sagarkapare merged 1 commit intodevelopfrom Dec 17, 2020
Merged
CDAP-17472 Make consumer id optional for mysql plugin.#122sagarkapare merged 1 commit intodevelopfrom
sagarkapare merged 1 commit intodevelopfrom
Conversation
| another Delta Replicator that is reading from the server, and it cannot be the same as the server-id for any MySQL | ||
| slave that is replicating from the server. | ||
| **Consumer ID:** Optional unique numeric ID to identify this origin as an event consumer. This number cannot be the | ||
| same as another Delta Replicator that is reading from the server, and it cannot be the same as the server-id for any |
Contributor
There was a problem hiding this comment.
If we append an instance Id after it, is it still required to be different from the one used by another Replicator ?
Contributor
There was a problem hiding this comment.
Instance id will be same between different replicators ?
Contributor
Author
There was a problem hiding this comment.
yes.. its integer that starts with 0.
| configBuilder = configBuilder.with("database.server.id", config.getConsumerID() + context.getInstanceId()); | ||
| } | ||
|
|
||
| Configuration debeziumConf = configBuilder.build(); |
Contributor
There was a problem hiding this comment.
nit: we don't need this intermediate variable ?
Contributor
Author
There was a problem hiding this comment.
oh its used on line 150 as well.
seanzhougoogle
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not provided, debezium picks random value for
database.server.id. - Reference: https://debezium.io/documentation/reference/1.3/connectors/mysql.html