support schema for SQL Server Table Registry #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertshau
approved these changes
Oct 13, 2021
Contributor
albertshau
left a comment
albertshau
left a comment
There was a problem hiding this comment.
minor comments, otherwise lgtm
| @Override | ||
| public TableDetail describeTable(String db, String table) throws TableNotFoundException, IOException { | ||
| return describeTable(db, null, table); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: add a newline between methods
| } | ||
| @Override | ||
| public TableDetail describeTable(String db, @Nullable String schema, String table) throws TableNotFoundException, | ||
| IOException { |
| private Optional<TableDetail.Builder> getTableDetailBuilder(DatabaseMetaData dbMeta, String db, String table) | ||
| throws SQLException { | ||
| private Optional<TableDetail.Builder> getTableDetailBuilder(DatabaseMetaData dbMeta, String db, | ||
| @Nullable String schema, String table) throws SQLException { |
seanzhougoogle
added a commit
that referenced
this pull request
Oct 13, 2021
support schema for SQL Server Table Registry
seanzhougoogle
added a commit
that referenced
this pull request
Oct 13, 2021
support schema for SQL Server Table Registry
seanzhougoogle
added a commit
that referenced
this pull request
Oct 13, 2021
seanzhougoogle
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.