Skip to content

[CDAP-16361] Exclude mssql-jdbc dependency from SqlServer-Delta-Plugin#35

Merged
shifuxu0301 merged 2 commits intodevelopfrom
bugfix/CDAP-16361-Exclude-Maven-MSSQL-JDBC-Dependency-For-Sql-Server
Mar 5, 2020
Merged

[CDAP-16361] Exclude mssql-jdbc dependency from SqlServer-Delta-Plugin#35
shifuxu0301 merged 2 commits intodevelopfrom
bugfix/CDAP-16361-Exclude-Maven-MSSQL-JDBC-Dependency-For-Sql-Server

Conversation

@shifuxu0301
Copy link
Copy Markdown
Contributor

  1. Exclude the mssql-jdbc from the pom file, meaning we will not package the sql server driver into cdap.
  2. Load/use the sql-server jdbc jar at configure time, so that we can reuse the class loader to load jdbc related class in debezium side.
  3. Did some hacky solution to copy the SqlServerConnection class from debezium and make connection factory a static variable for resetting purpose in sql-server event reader.

Testing:
Tested on CDAP, it works as expected.

@shifuxu0301 shifuxu0301 requested a review from albertshau March 5, 2020 20:15
Copy link
Copy Markdown
Contributor

@albertshau albertshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise lgtm

Comment thread sqlserver-delta-plugins/pom.xml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants