Added logic to ensure batches are submitted to the engine every 1k records. #185
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivv
reviewed
Feb 3, 2022
| // Submit a batch to the SQL engine every 10k records | ||
| // This is done to reduce memory usage in the worker, as processed records can now be GC'd. | ||
| numWrittenRecords++; | ||
| if (numWrittenRecords % 10000 == 0) { |
Contributor
There was a problem hiding this comment.
Can we have this 10K configurable? In some rare cases 10K can be too high (E.g. in CDF our internal records are multimeg, customer may have it). Don't need ui, but a runtime argument would be nice
fernst
force-pushed
the
ensure-batches-every-10k-records
branch
from
df97de6 to
69630a2
Compare
tivv
approved these changes
Feb 3, 2022
fernst
force-pushed
the
ensure-batches-every-10k-records
branch
from
69630a2 to
8883bd3
Compare
fernst
changed the title
…cords by default. This is configurable using a pipeline argument. This prevents the workers from running out of memory for large partitions.
fernst
force-pushed
the
ensure-batches-every-10k-records
branch
from
8883bd3 to
4081484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the workers from running out of memory for large partitions.