[PLUGIN-994] Adding setFetchSize to the database plugins #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
PLUGIN-994
branch
2 times, most recently
from
d9bef18 to
85948ac
Compare
tivv
reviewed
Dec 10, 2021
| @Override | ||
| public Map<String, String> getConnectionArguments() { | ||
| Map<String, String> arguments = new HashMap<>(super.getConnectionArguments()); | ||
| // If connected to MySQL > 5.0.2, and setFetchSize() > 0 on a statement, |
Contributor
There was a problem hiding this comment.
I think this should go into getDBSpecificArguments. Also Please add a check for fetch size. If for whatever reason it's <=0 we should not add this argument
tivv
reviewed
Dec 14, 2021
|
|
||
| @Override | ||
| public Integer getFetchSize() { | ||
| return 0; |
Contributor
There was a problem hiding this comment.
Why don't we add proper fetchSize here?
tivv
reviewed
Dec 14, 2021
Contributor
tivv
left a comment
tivv
left a comment
There was a problem hiding this comment.
Does this cover CloudSQL plugins?
Contributor
|
I see that CloudSQL plugins descent from io.cdap.plugin.db.batch.source.AbstractDBSource.DBSourceConfig and that one has hard coded "0" as fetch size |
Contributor
Author
|
Yes, it does cover CloudSQL plugins as discussed offline. |
tivv
approved these changes
Dec 15, 2021
itsankit-google
force-pushed
the
PLUGIN-994
branch
from
1cced6f to
749cb0b
Compare
This was referenced Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLUGIN-994