add logic for TNS Descriptor#216
Merged
sagarkapare merged 1 commit intodata-integrations:developfrom Mar 3, 2022
jster1357:develop
Merged
add logic for TNS Descriptor#216sagarkapare merged 1 commit intodata-integrations:developfrom jster1357:develop
sagarkapare merged 1 commit intodata-integrations:developfrom
jster1357:develop
Conversation
Contributor
|
Can you please help resolve the conflict? Also compilation failed for me with RAT checkstyle error and had to add these small one liner changes - https://github.com/data-integrations/database-plugins/pull/224/files#diff-afe65e631b8b5b1d360af43ae84dc844e2c55ee83e9179cdb8bd087da954ae06R61 and https://github.com/data-integrations/database-plugins/pull/224/files#diff-2716241b8a597dc62a7410ef315a08de5c0336cd3d8b1a85af83ca212a103f3cR37 |
sagarkapare
approved these changes
Mar 3, 2022
Contributor
sagarkapare
left a comment
sagarkapare
left a comment
There was a problem hiding this comment.
Resolved conflicts on behalf of Justin. Code changes in the PR LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.