[CDAP-18170] Change JDBC Driver Name to required for all databases#231
Merged
sumengwang merged 3 commits intodevelopfrom Mar 17, 2022
Merged
[CDAP-18170] Change JDBC Driver Name to required for all databases#231sumengwang merged 3 commits intodevelopfrom
sumengwang merged 3 commits intodevelopfrom
Conversation
itsankit-google
approved these changes
Mar 17, 2022
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
LGTM
Can the UI prompt be closed automatically after sometime? It does not go until the user clicks on close dialog at the top right.
Contributor
Author
|
@itsankit-google Do you want to make a separate ticket on that? I noticed this behavior in multiple places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CDAP-18170] Change JDBC Driver Name to required for all databases
Description
Change JDBC Driver Name field to be required. If empty when clicking Test Connection, UI will prompt alerts and prevent the request
Links
CDAP-18170
Screenshots