Skip to content

[PLUGIN-1512] Fix/result set indexing issue #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MrRahulSharma merged 1 commit into from
Feb 24, 2023
Merged

[PLUGIN-1512] Fix/result set indexing issue #356

MrRahulSharma merged 1 commit into from
Feb 24, 2023

Conversation

@MrRahulSharma
Copy link
Contributor

@MrRahulSharma MrRahulSharma commented Feb 23, 2023

JIRA : https://cdap.atlassian.net/browse/PLUGIN-1512

Fixed a similar issue in the AbstractDBSink as well.

@itsankit-google itsankit-google changed the title Fix/result set indexing issue [PLUGIN-1512] Fix/result set indexing issue Feb 23, 2023
itsankit-google
itsankit-google approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits, otherwise LGTM.

@itsankit-google
Copy link
Contributor

itsankit-google commented Feb 23, 2023 •
edited
Loading

Please fix the unit tests failures.

Error:  Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.355 s <<< FAILURE! - in io.cdap.plugin.db.batch.sink.AbstractDBSinkTest
Error:  testGetMatchedColumnTypeList(io.cdap.plugin.db.batch.sink.AbstractDBSinkTest)  Time elapsed: 0.288 s  <<< ERROR!
java.sql.SQLException: No column with name ID found
	at io.cdap.plugin.db.batch.sink.AbstractDBSinkTest.testGetMatchedColumnTypeList(AbstractDBSinkTest.java:60)

Error:  testSubsetColumnsInResultSet(io.cdap.plugin.db.batch.sink.AbstractDBSinkTest)  Time elapsed: 0 s  <<< ERROR!
java.sql.SQLException: No column with name SCORE found
	at io.cdap.plugin.db.batch.sink.AbstractDBSinkTest.testSubsetColumnsInResultSet(AbstractDBSinkTest.java:191)

Error:  testDifferentOrderOfFieldsInResultSet(io.cdap.plugin.db.batch.sink.AbstractDBSinkTest)  Time elapsed: 0 s  <<< ERROR!
java.sql.SQLException: No column with name NAME found
	at io.cdap.plugin.db.batch.sink.AbstractDBSinkTest.testDifferentOrderOfFieldsInResultSet(AbstractDBSinkTest.java:143)

@MrRahulSharma
Fixing the ResultSet look up logic to look against the column name in…
ab9b8e6 
…stead of field index from Schema.

Removed the buggy logic of index in Oracle plugin
@MrRahulSharma MrRahulSharma force-pushed the fix/ResultSetIndexingIssue branch from eb7b1d6 to ab9b8e6 Compare February 24, 2023 05:27
@MrRahulSharma MrRahulSharma merged commit 2f5803e into develop Feb 24, 2023
@itsankit-google itsankit-google deleted the fix/ResultSetIndexingIssue branch February 24, 2023 08:13
Nikitapaliwal123 pushed a commit that referenced this pull request Mar 24, 2023
@MrRahulSharma @Nikitapaliwal123
Fixing the ResultSet look up logic to look against the column name in…
a698024 
…stead of field index from Schema. (#356)

Removed the buggy logic of index in Oracle plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

@albertshau albertshau Awaiting requested review from albertshau

@sau42shri sau42shri Awaiting requested review from sau42shri

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MrRahulSharma @itsankit-google