PLUGIN-1535 : Oracle decimal type Backward Compatibility Fix #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivv
reviewed
Mar 11, 2023
Contributor
tivv
left a comment
tivv
left a comment
There was a problem hiding this comment.
Please add a unit test for the fallback and refer respective JIRA in the PR title
MrRahulSharma
changed the title
Contributor
Author
Added Unit Test to validate if the schema is Decimal and does not match with the expected String type. |
MrRahulSharma
force-pushed
the
fix/BackwardCompatibilityForPrecisionLessNumberHandling
branch
from
624c82a to
1a47e7d
Compare
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSource.java
Outdated
Show resolved
Hide resolved
albertshau
reviewed
Mar 13, 2023
oracle-plugin/src/test/java/io/cdap/plugin/oracle/OracleSourceDBRecordUnitTest.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/test/java/io/cdap/plugin/oracle/OracleSourceDBRecordUnitTest.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/test/java/io/cdap/plugin/oracle/OracleSourceDBRecordUnitTest.java
Show resolved
Hide resolved
MrRahulSharma
force-pushed
the
fix/BackwardCompatibilityForPrecisionLessNumberHandling
branch
from
c78eb6e to
5ddedea
Compare
fernst
reviewed
Mar 13, 2023
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Outdated
Show resolved
Hide resolved
albertshau
approved these changes
Mar 13, 2023
itsankit-google
approved these changes
Mar 14, 2023
MrRahulSharma
force-pushed
the
fix/BackwardCompatibilityForPrecisionLessNumberHandling
branch
from
90e3e08 to
6f3056e
Compare
MrRahulSharma
added a commit
that referenced
this pull request
Mar 14, 2023
MrRahulSharma
added a commit
that referenced
this pull request
Mar 14, 2023
MrRahulSharma
added a commit
that referenced
this pull request
Mar 14, 2023
MrRahulSharma
added a commit
that referenced
this pull request
Mar 14, 2023
Nikitapaliwal123
pushed a commit
that referenced
this pull request
Mar 24, 2023
Nikitapaliwal123
pushed a commit
that referenced
this pull request
Mar 24, 2023
author Rahul Sharma <112750762+MrRahulSharma@users.noreply.github.com> 1678782133 +0530 committer nikitapaliwal <nikitapaliwal@google.com> 1679646615 +0530 parent 3fb6a10 author Rahul Sharma <112750762+MrRahulSharma@users.noreply.github.com> 1678782133 +0530 committer nikitapaliwal <nikitapaliwal@google.com> 1679646564 +0530 Backward Compatibility Fix for Oracle Number type without precision and scale. (#365) Created basic infra of e2e tests for SQL Server plugin (#363) * Created basic infra of e2e tests for SQL Server plugin * Created basic infra of e2e tests for SQL Server plugin * Created basic infra of e2e tests for SQL Server plugin * Created basic infra of e2e tests for SQL Server plugin * Created basic infra of e2e tests for SQL Server plugin * Basic e2e infra for mssql * e2e infra sanity tests sanity tests sanity tests sanity tests sanity tests sanity tests sanity tests sanity tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backward compatibility fix for Oracle number type with undefined precision and scale.
JIRA : https://cdap.atlassian.net/browse/PLUGIN-1535