Skip to content

Changed the logic to handle datetime datatype #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nikitapaliwal123 merged 4 commits into from
Apr 6, 2023
Merged

Changed the logic to handle datetime datatype #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f65ab90
Changed the logic to handle datetime datatype
Nikitapaliwal123 Apr 5, 2023
3cd75c4
Merge branch 'develop' into sql_server_data_type_validate
Nikitapaliwal123 Apr 5, 2023
6c64afc
Changed the logic to handle datetime datatype
Nikitapaliwal123 Apr 5, 2023
f2a1413
Changed the logic to handle datetime datatype
Nikitapaliwal123 Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions database-commons/src/main/java/io/cdap/plugin/db/DBRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ protected void writeToDB(PreparedStatement stmt, @Nullable Schema.Field field, i
case DECIMAL:
stmt.setBigDecimal(sqlIndex, record.getDecimal(fieldName));
break;
case DATETIME:
stmt.setTimestamp(sqlIndex, Timestamp.valueOf(record.getDateTime(fieldName)));
break;
}
return;
}
Expand Down
8 changes: 8 additions & 0 deletions mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlFieldsValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ public boolean isFieldCompatible(Schema.Field field, ResultSetMetaData metadata,
boolean isSigned = metadata.isSigned(index);
int precision = metadata.getPrecision(index);

Copy link
Contributor

@MrRahulSharma MrRahulSharma Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here about the use cases you are handling here.

Copy link
Contributor

@MrRahulSharma MrRahulSharma Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more details.

// Handles datetime datatypes
// Case when Timestamp maps to datetime
// Case when Datetime2 maps to datetime
// Case when DatetimeOffset maps to datetime
if ((sqlType == Types.TIMESTAMP || sqlType == SqlServerSourceSchemaReader.DATETIME_OFFSET_TYPE)
&& fieldLogicalType.equals(Schema.LogicalType.DATETIME)) {
return true;
}
// Handle logical types first
if (fieldLogicalType != null) {
return super.isFieldCompatible(fieldType, fieldLogicalType, sqlType, precision, isSigned);
Expand Down