e2e-tests for Oracle plugins #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

itsankit-google merged 1 commit into data-integrations:develop from cloudsufi:e2e_oracle

Jul 20, 2023

Contributor

poojantcs commented Apr 17, 2023 •

edited

Loading

@Vipinofficial11 @itsmekumari

sau42shri requested review from Aryan-Verma, MrRahulSharma, Nikitapaliwal123, sumitjnn and vanathi-g

April 18, 2023 05:22

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/resources/errorMessage.properties Outdated Show resolved Hide resolved

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/resources/errorMessage.properties Outdated Show resolved Hide resolved

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/resources/errorMessage.properties Outdated Show resolved Hide resolved

itsankit-google added the build label

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/features/sink/OracleDesignTime.feature Outdated Show resolved Hide resolved

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

Aryan-Verma reviewed

View reviewed changes

oracle-plugin/src/e2e-test/features/source/OracleRunTime.feature Outdated Show resolved Hide resolved

Contributor

itsankit-google commented Apr 18, 2023

I suggested to add @Oracle_Required tag so that we can verify the tests run successfully with github actions.

But before merging the PR, please check with @Aryan-Verma and @MrRahulSharma if we need to add the tag to all or some specific tests because overall the required tests should not take more than 15mins to avoid blocking PR merges for longer time.

MrRahulSharma reviewed

View reviewed changes

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/sink/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/source/OracleRunTimeMacro.feature Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/source/OracleDesignTimeValidation.feature Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/source/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/features/source/OracleDesignTimeValidation.feature Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/resources/pluginParameters.properties Show resolved Hide resolved

MrRahulSharma reviewed

View reviewed changes

oracle-plugin/src/e2e-test/java/io.cdap.plugin/oracle/runners/TestRunner.java Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/java/io.cdap.plugin/oracle/runners/TestRunnerRequired.java Outdated Show resolved Hide resolved

oracle-plugin/src/e2e-test/resources/pluginParameters.properties Show resolved Hide resolved

MrRahulSharma reviewed

View reviewed changes

oracle-plugin/src/e2e-test/resources/pluginParameters.properties Outdated Show resolved Hide resolved

Vipinofficial11 force-pushed the e2e_oracle branch from 0d5c200 to f41e0de Compare

May 5, 2023 07:30

Vipinofficial11 force-pushed the e2e_oracle branch 2 times, most recently from 5af57ea to 3cb7c79 Compare

May 19, 2023 15:34

Aryan-Verma approved these changes

View reviewed changes

bharatgulati force-pushed the e2e_oracle branch from d370a14 to e92637a Compare

June 5, 2023 09:56

itsankit-google requested changes

View reviewed changes

Contributor

itsankit-google left a comment •

edited

Loading

I think there is an issue currently with the oracle tests running indefinitely.

Please fix before merging the PR.

bharatgulati force-pushed the e2e_oracle branch 3 times, most recently from 059b3e9 to 3ea051a Compare

June 7, 2023 12:36

Vipinofficial11 force-pushed the e2e_oracle branch from 3ea051a to 290e631 Compare

June 13, 2023 04:47

bharatgulati force-pushed the e2e_oracle branch 3 times, most recently from 5a98b49 to 87671f7 Compare

June 14, 2023 12:23

bharatgulati force-pushed the e2e_oracle branch from ea32133 to f3a2db2 Compare

June 22, 2023 04:54

itsmekumari force-pushed the e2e_oracle branch 4 times, most recently from 24b710c to 9155e2f Compare

July 14, 2023 08:49

Contributor Author

poojantcs commented Jul 18, 2023

Details

Hi @itsankit-google , we have a green build now and the commits are squashed as well.

@MrRahulSharma : Can we please merge this PR?

itsankit-google reviewed

View reviewed changes

oracle-plugin/src/e2e-test/java/io.cdap.plugin/oracle/BQValidation.java

    
               * BQValidation.

               */

              public class BQValidation {

Contributor

itsankit-google Jul 18, 2023

Why is this class not present in the same top level package as OracleClient?

Contributor

itsmekumari Jul 18, 2023

There is no such reason to use this class inside this package. Do we need to add it to OracleClient package, as we are using a different package for BQValidation class.

Contributor

itsankit-google Jul 18, 2023

I think we should keep all the common classes at one place.

Contributor

itsmekumari Jul 19, 2023

Change done.

Contributor

itsankit-google commented Jul 18, 2023

Details

Hi @itsankit-google , we have a green build now and the commits are squashed as well.

@MrRahulSharma : Can we please merge this PR?

Sorry, didn't saw it, added one comment/question.

itsmekumari force-pushed the e2e_oracle branch from 9870c58 to 2c5507f Compare

July 19, 2023 08:14


          e2e_Oracle tests

31eb54f

itsmekumari force-pushed the e2e_oracle branch from 5f43023 to 31eb54f Compare

July 19, 2023 15:52

itsankit-google approved these changes

View reviewed changes

itsankit-google merged commit 001496a into data-integrations:develop

psainics deleted the e2e_oracle branch

January 22, 2025 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MrRahulSharma MrRahulSharma left review comments

itsankit-google itsankit-google approved these changes

Nikitapaliwal123 Awaiting requested review from Nikitapaliwal123

sumitjnn Awaiting requested review from sumitjnn

vanathi-g Awaiting requested review from vanathi-g

+2 more reviewers

itsmekumari itsmekumari left review comments

Aryan-Verma Aryan-Verma approved these changes

Labels