e2e-tests for MySQL plugins #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sau42shri
requested review from
Aryan-Verma,
MrRahulSharma,
Nikitapaliwal123,
sumitjnn and
vanathi-g
Aryan-Verma
reviewed
Apr 18, 2023
Aryan-Verma
reviewed
Apr 18, 2023
mysql-plugin/src/e2e-test/features/mysqlsink/DesignTimeValidation.feature
Outdated
Show resolved
Hide resolved
Contributor
|
Please ensure that we only configure the required node for testing in the validation tests. For example: We should ideally be using only Sink node to validate the config in the Sink and using only the source node to validate the config in the source. |
mysql-plugin/src/e2e-test/features/mysqlsink/DesignTime.feature
Outdated
Show resolved
Hide resolved
mysql-plugin/src/e2e-test/features/mysqlsink/DesignTimeValidation.feature
Outdated
Show resolved
Hide resolved
mysql-plugin/src/e2e-test/features/mysqlsink/DesignTimeValidation.feature
Show resolved
Hide resolved
priyabhatnagar25
force-pushed
the
mysql-e2e
branch
from
772f7fd to
96be7be
Compare
Aryan-Verma
reviewed
Apr 24, 2023
Vipinofficial11
force-pushed
the
mysql-e2e
branch
4 times, most recently
from
31de6bb to
0507cea
Compare
mysql-plugin/src/e2e-test/java/io/cdap/plugin/mysql/actions/MySQLPropertiesPageActions.java
Outdated
Show resolved
Hide resolved
mysql-plugin/src/e2e-test/java/io/cdap/plugin/mysql/locators/MySQLPropertiesPage.java
Outdated
Show resolved
Hide resolved
mysql-plugin/src/e2e-test/features/mysqlsource/Datatypes.feature
Outdated
Show resolved
Hide resolved
priyabhatnagar25
force-pushed
the
mysql-e2e
branch
from
0b705d8 to
54cf830
Compare
Aryan-Verma
approved these changes
May 31, 2023
Nikitapaliwal123
approved these changes
May 31, 2023
bharatgulati
force-pushed
the
mysql-e2e
branch
5 times, most recently
from
4ceb9be to
238eda5
Compare
MrRahulSharma
approved these changes
Jun 23, 2023
itsmekumari
pushed a commit
to cloudsufi/database-plugins
that referenced
this pull request
Jul 14, 2023
Co-authored-by: priyabhatnagar <priya.bhatnagar@cloudsufi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Vipinofficial11 @priyabhatnagar25