[Plugin-1614][Plugin-1507][Plugin-1615][Plugin-1611] Int datatype changes #390
Conversation
MrRahulSharma
force-pushed
the
fix/MediumIntFix
branch
from
3d4c4e7 to
575cd8d
Compare
MrRahulSharma
changed the title
MrRahulSharma
changed the title
MrRahulSharma
force-pushed
the
fix/MediumIntFix
branch
from
7e239ad to
940e3ce
Compare
MrRahulSharma
force-pushed
the
fix/MediumIntFix
branch
from
403dd5a to
800314e
Compare
mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlConnectorConfig.java
Show resolved
Hide resolved
mysql-plugin/docs/Mysql-batchsink.md
Outdated
| | BOOL, BOOLEAN | boolean | | | ||
| | SMALLINT | int | | | ||
| | MEDIUMINT | double | | | ||
| | MEDIUMINT | int | Users can manually set output schema to map it to Long. | |
There was a problem hiding this comment.
what does this comment mean? There is no output schema for a sink.
There was a problem hiding this comment.
There is similar existing comment for YEAR. Seems like this table was just copied from the source? For a sink I would expect to find what CDAP types can be written to which MySQL types
There was a problem hiding this comment.
Currently, all the Sink documents present in the database-plugins project contain a copy of mapping details from their source plugins. I believe it might be a little tricky in adding a CDAP to sink type mapping, given we have multiple types mapped to single sink types. I feel that might be a bigger documentation change, which might require some more thoughts.
There was a problem hiding this comment.
ok, though can we remove the comments column in the sink doc? I think it's pretty confusing.
There was a problem hiding this comment.
I will work on this comment in the next set of changes, proposing to take this after this PR submission.
mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlConnectorConfig.java
Show resolved
Hide resolved
mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlDBRecord.java
Outdated
Show resolved
Hide resolved
MrRahulSharma
force-pushed
the
fix/MediumIntFix
branch
from
b4fc77d to
e6f0e41
Compare
MrRahulSharma
force-pushed
the
fix/MediumIntFix
branch
from
0678238 to
4a1b678
Compare
| prop.put(JDBC_PROPERTY_SOCKET_TIMEOUT, "20000"); | ||
| prop.put(JDBC_REWRITE_BATCHED_STATEMENTS, "true"); | ||
| // MySQL property to ensure that TINYINT(1) type data is not converted to MySQL Bit/Boolean type in the ResultSet. | ||
| prop.put(MYSQL_TINYINT1_IS_BIT, "false"); |
There was a problem hiding this comment.
Does it makes sense to use putIfAbsent() so that if user has provided it in connection args in plugin config we don't end up overriding it?
5 participants
JIRA
https://cdap.atlassian.net/browse/PLUGIN-1614
https://cdap.atlassian.net/browse/PLUGIN-1507
https://cdap.atlassian.net/browse/PLUGIN-1615
https://cdap.atlassian.net/browse/PLUGIN-1611