[PLUGIN-1518][PLUGIN-1526] Fixed the timestamp handling to DateTime #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrRahulSharma
requested review from
Aryan-Verma,
Nikitapaliwal123,
albertshau,
itsankit-google and
sau42shri
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Please add a unit test.
Aryan-Verma
approved these changes
May 31, 2023
MrRahulSharma
force-pushed
the
fix/TimestampTypeFix
branch
from
0bede64 to
d4a0a23
Compare
itsankit-google
approved these changes
Jun 21, 2023
itsmekumari
pushed a commit
to cloudsufi/database-plugins
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA :
https://cdap.atlassian.net/browse/PLUGIN-1518
https://cdap.atlassian.net/browse/PLUGIN-1526
Postgres Timestamp type does not have a timezone information. Current handling creates an offset in the Sink plugin. Hence converting the handling of the PostgreSQL Timestamp type into Datetime type ensuring backward compatibility with the Timestamp type.