[Plugin 1522] Enabling support for the precision less numbers in PostgreSQL plugin. #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrRahulSharma
force-pushed
the
fix/PrecisionLessDecimalNumberSupport
branch
from
1d075a3 to
3531e5b
Compare
postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresDBRecord.java
Outdated
Show resolved
Hide resolved
MrRahulSharma
force-pushed
the
fix/PrecisionLessDecimalNumberSupport
branch
from
f77ce36 to
fc401cc
Compare
itsankit-google
approved these changes
Jun 14, 2023
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Minor comments, otherwise LGTM.
MrRahulSharma
force-pushed
the
fix/PrecisionLessDecimalNumberSupport
branch
from
ee7b00a to
c286d0f
Compare
itsmekumari
pushed a commit
to cloudsufi/database-plugins
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the precision less numbers into String type and ensuring that they are compatible with the Postgres Sink as well.
Related JIRA :
https://cdap.atlassian.net/browse/PLUGIN-1522