Skip to content

cloudSql-mySql e2e #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sumitjnn merged 1 commit into from
Jul 20, 2023
Merged

cloudSql-mySql e2e #408

sumitjnn merged 1 commit into from
Jul 20, 2023

Conversation

@bharatgulati
Copy link
Contributor

@bharatgulati bharatgulati commented Jun 14, 2023

cloudsql-mysql e2e

@bharatgulati bharatgulati marked this pull request as ready for review June 14, 2023 06:56
@bharatgulati bharatgulati force-pushed the cloudSQL-mySQL-e2e branch 5 times, most recently from 411a5c0 to 6905e24 Compare June 15, 2023 04:29
@Vipinofficial11 Vipinofficial11 marked this pull request as draft June 15, 2023 07:38
@bharatgulati bharatgulati force-pushed the cloudSQL-mySQL-e2e branch 6 times, most recently from 3f7326e to 38c502d Compare June 21, 2023 04:58
@bharatgulati bharatgulati marked this pull request as ready for review June 21, 2023 04:59
@sumitjnn sumitjnn self-assigned this Jul 14, 2023
sumitjnn
sumitjnn reviewed Jul 14, 2023
View reviewed changes
cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/stepsdesign/CloudMysql.java Outdated
}
}


Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove extra empty line

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra line.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/stepsdesign/package-info.java Outdated
package io.cdap.plugin.cloudmysql.stepsdesign;



Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove extra empty line

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/runners/package-info.java Outdated
@@ -0,0 +1,21 @@
/*
* Copyright © 2022 Cask Data, Inc.
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix year

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to '2023'

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/runners/TestRunner.java Outdated
Comment on lines 39 to 42



Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove extra empty lines (keep only 1)

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra line.

cloudsql-mysql-plugin/src/e2e-test/features/source/CloudMySqlDesignTime.feature Outdated
## License for the specific language governing permissions and limitations under
# the License..

@CloudMySql
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be a required test (@CloudMySql_Required) similar to the one for sink (cloudsql-mysql-plugin/src/e2e-test/features/sink/CloudMySqlDesignTime.feature)?

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Required tag has been included for every feature of the source and sink. Added the @CloudMySql_Required tag to this feature.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/CloudMySqlClient.java Outdated
ResultSet rs = statement.executeQuery(countQuery)) {
int num = 0;
while (rs.next()) {
num = (rs.getInt(1));
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
num = (rs.getInt(1));
num = rs.getInt(1);

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/CloudMySqlClient.java Outdated

public static void createTargetDatatypesTable(String targetTable) throws SQLException, ClassNotFoundException {
try (Connection connect = getCloudSqlConnection(); Statement statement = connect.createStatement()) {
String datatypesColumns = PluginPropertyUtils.pluginProp("datatypesColumns");
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use constant

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with constants.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/BQValidation.java Outdated
public static List<Object> bigQueryRows = new ArrayList<>();
public static Gson gson = new Gson();

public static void main(String[] args) throws SQLException, ClassNotFoundException {
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the main method

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the main function.

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/cloudmysql/stepsdesign/CloudMysql.java Outdated

boolean recordsMatched = BQValidation.validateDBAndBQRecordValues(
PluginPropertyUtils.pluginProp("sourceTable"),
PluginPropertyUtils.pluginProp("bqTargetTable"));
Copy link
Contributor

@sumitjnn sumitjnn Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constants

Copy link
Contributor Author

@bharatgulati bharatgulati Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjhawar yjhawar self-assigned this Jul 19, 2023
@sumitjnn
Copy link
Contributor

sumitjnn commented Jul 19, 2023

Please check and fix build failures

@sumitjnn sumitjnn added build and removed build labels Jul 19, 2023
@sumitjnn
Copy link
Contributor

sumitjnn commented Jul 19, 2023

Let's ensure e2e build passes before merging

@bharatgulati bharatgulati force-pushed the cloudSQL-mySQL-e2e branch 4 times, most recently from 6ab4ca0 to 9e0903d Compare July 20, 2023 09:20
@sumitjnn sumitjnn merged commit cb5e3ee into data-integrations:develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sumitjnn sumitjnn sumitjnn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sumitjnn sumitjnn

@yjhawar yjhawar

@bharatgulati bharatgulati

Labels

build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharatgulati @sumitjnn @Vipinofficial11 @yjhawar