Skip to content

Conversation

@vladhlinskiy
Copy link
Contributor

JIRA: https://issues.cask.co/browse/CDAP-15551
WIKI: https://wiki.cask.co/display/CE/DB2+database+plugin

In scope of this PR:

  • Added tests for Source plugin for next types:
VARGRAPHIC, DBCLOB, BINARY, VARBINARY
  • Added tests for Sink plugin for next types:
SMALLINT, INTEGER, BIGINT, DECIMAL(p,s) and NUMERIC(p,s), DECFLOAT, REAL, DOUBLE, CHAR, CHAR FOR BIT DATA, VARCHAR FOR BIT DATA, BINARY, VARBINARY, GRAPHIC, VARGRAPHIC, DBCLOB
  • DECFLOAT is mapped to the Type.STRING

  • Mappings added to the reference documentation

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@vladhlinskiy
Copy link
Contributor Author

@albertshau could you, please, take a look?

Copy link
Contributor

@albertshau albertshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albertshau albertshau merged commit eff7e9e into data-integrations:develop Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants