Skip to content

[🍒][PLUGIN-1873] Error Management AbstractDBAction #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psainics merged 1 commit into from
Apr 2, 2025
Merged

[🍒][PLUGIN-1873] Error Management AbstractDBAction #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion database-commons/src/main/java/io/cdap/plugin/db/action/AbstractDBAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@

package io.cdap.plugin.db.action;

import io.cdap.cdap.etl.api.FailureCollector;
import io.cdap.cdap.etl.api.PipelineConfigurer;
import io.cdap.cdap.etl.api.action.Action;
import io.cdap.cdap.etl.api.action.ActionContext;
import io.cdap.plugin.common.db.DBErrorDetailsProvider;
import io.cdap.plugin.util.DBUtils;

import java.sql.Driver;
import java.sql.SQLException;

/**
* Action that runs a db command.
Expand All @@ -40,7 +43,18 @@ public AbstractDBAction(QueryConfig config, Boolean enableAutoCommit) {
public void run(ActionContext context) throws Exception {
Class<? extends Driver> driverClass = context.loadPluginClass(JDBC_PLUGIN_ID);
DBRun executeQuery = new DBRun(config, driverClass, enableAutoCommit);
executeQuery.run();
try {
executeQuery.run();
} catch (Exception e) {
if (e instanceof SQLException) {
DBErrorDetailsProvider dbe = new DBErrorDetailsProvider();
throw dbe.getProgramFailureException((SQLException) e, null);
}
FailureCollector collector = context.getFailureCollector();
collector.addFailure("Failed to execute query with message: " + e.getMessage(), null)
.withStacktrace(e.getStackTrace());
collector.getOrThrowException();
}
}

@Override
Expand Down
Loading