Skip to content

Changed Decimal Type Mapping #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Changed Decimal Type Mapping #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ private void handleOracleSpecificType(ResultSet resultSet, StructuredRecord.Buil
// This is the only way to differentiate FLOAT/REAL columns from other numeric columns, that based on NUMBER.
// Since FLOAT is a subtype of the NUMBER data type, 'getColumnType' and 'getColumnTypeName' can not be used.
if (Double.class.getTypeName().equals(resultSet.getMetaData().getColumnClassName(columnIndex))) {
recordBuilder.set(field.getName(), resultSet.getDouble(columnIndex));
recordBuilder.setDecimal(field.getName(), BigDecimal.valueOf(resultSet.getDouble(columnIndex)));
} else {
// It's required to pass 'scale' parameter since in the case of Oracle, scale of 'BigDecimal' depends on the
// scale of actual value. For example for value '77.12' scale will be '2' even if sql scale is '6'
Expand Down