Conversation
fernst
requested review from
albertshau,
chtyim,
greeshmaswaminathan,
rmstar,
sechegaray and
tivv
| <name>Google Cloud BigQuery Plugins</name> | ||
| <description>BigQuery GCP Plugins</description> | ||
|
|
||
| <distributionManagement> |
There was a problem hiding this comment.
Do these change for submodules? I think it would keep the submodule pom files simpler if the common parts like distributionManagement, repository, checkstyle, build and even the common dependencies like cdap-api is moved to the top level pom. wdyt?
There was a problem hiding this comment.
This is a great point. I will consolidate some of the common dependencies in the parent pom (CDAP API modules that are in the provided scope and test dependencies)
There was a problem hiding this comment.
nit: Move the section and section also to parent pom?
fernst
force-pushed
the
gcp-modules-2
branch
2 times, most recently
from
9701dd3 to
a67d218
Compare
|
How will we handle the import for pipeline json prior to 6.8.0? With this change, the pipeline json won't be able to find the correct artifact in the new instance. |
|
One of the follow up items to this change is to add logic on the pipeline upgrader to handle pre-6.8 GCP artifacts |
Applied latest repository changes and cleanup Moved E2E tests to separate submodule Applied latest repository changes Simplied pom Renamed storage module
|
TODOs after this PR is merged:
|
3 participants
Applied latest repository changes and cleanup
Moved E2E tests to separate submodule
Applied latest repository changes