GCS all types e2e tests#1301
Merged
yjhawar merged 1 commit intodata-integrations:developfrom Sep 20, 2023
Merged
Conversation
bharatgulati
force-pushed
the
gcs_allTypes
branch
from
55e6dc3 to
3bad0a8
Compare
yjhawar
reviewed
Sep 15, 2023
| public static boolean validateGCSSourceToGCSSink(String bucketName) throws IOException { | ||
| Map<String, JsonObject> expectedAvroData = convertAvroToJsonWithKeys(); | ||
| Map<String, JsonObject> actualGcsData = listBucketObjects(bucketName); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: these lines in between aren't required
Contributor
Author
There was a problem hiding this comment.
Removed extra line.
yjhawar
reviewed
Sep 15, 2023
| if (!bucketObjectNames.isEmpty()) { | ||
| String objectName = bucketObjectNames.get(0); | ||
| if (objectName.contains("part-r")) { | ||
| Map<String, JsonObject> dataMap2 = fetchObjectData(projectId, bucketName, objectName); |
Contributor
There was a problem hiding this comment.
nit: suffix 2 isn't required here
Contributor
Author
There was a problem hiding this comment.
Changed it to 'dataMap'
yjhawar
reviewed
Sep 15, 2023
|
|
||
| try (FileReader<GenericRecord> dataFileReader = DataFileReader.openReader(avroFile, datumReader)) { | ||
| int keyCounter = 1; | ||
|
|
yjhawar
approved these changes
Sep 15, 2023
Contributor
yjhawar
left a comment
yjhawar
left a comment
There was a problem hiding this comment.
LGTM with minor comments
bharatgulati
force-pushed
the
gcs_allTypes
branch
from
3bad0a8 to
f9ccb19
Compare
bharatgulati
force-pushed
the
gcs_allTypes
branch
from
f9ccb19 to
2a29744
Compare
Contributor
|
Builds are failing. can you fix them |
bharatgulati
added
build
Contributor
Author
Due to an intermittent problem (Chrome version issue), builds are failing. For the same, an issue was previously raised. Link. An error message was changed but the cause is same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.