bq additional scenarios#1317
Merged
DJSagarAhire merged 1 commit intodata-integrations:developfrom Dec 4, 2023
Merged
Conversation
bharatgulati
added
build
priyabhatnagar25
force-pushed
the
tests_new_e2e_bq
branch
7 times, most recently
from
f9b5cef to
05b2a5e
Compare
priyabhatnagar25
force-pushed
the
tests_new_e2e_bq
branch
from
05b2a5e to
368a28a
Compare
| <goals> | ||
| <goal>integration-test</goal> | ||
| <goal>verify</goal> | ||
| <!-- <goal>verify</goal>--> |
Contributor
There was a problem hiding this comment.
Why is this commented out?
Contributor
Author
There was a problem hiding this comment.
Hi Sagar , this is resolved
| @Before(order = 1, value = "@BQ_UPSERT_SOURCE_TEST") | ||
| public static void createSourceBQUpsertTable() throws IOException, InterruptedException { | ||
| bqSourceTable = "E2E_SOURCE_" + UUID.randomUUID().toString().replaceAll("-", "_"); | ||
| io.cdap.e2e.utils.BigQueryClient.getSoleQueryResult("create table `" + datasetName + "." + bqSourceTable + "` " + |
Contributor
There was a problem hiding this comment.
Is there a reason we can't import the BigQueryClient class or static import the getSoleQueryResult method?
| public static void createSourceBQUpsertTable() throws IOException, InterruptedException { | ||
| bqSourceTable = "E2E_SOURCE_" + UUID.randomUUID().toString().replaceAll("-", "_"); | ||
| io.cdap.e2e.utils.BigQueryClient.getSoleQueryResult("create table `" + datasetName + "." + bqSourceTable + "` " + | ||
| "(ID INT64, Name STRING, " + "Price FLOAT64," + |
Contributor
There was a problem hiding this comment.
Please use String.format() for SQL queries rather than concatenation with +. In fact it's preferable to make this change throughout.
priyabhatnagar25
force-pushed
the
tests_new_e2e_bq
branch
from
368a28a to
e0f7676
Compare
bharatgulati
added
build
DJSagarAhire
approved these changes
Dec 4, 2023
priyabhatnagar25
force-pushed
the
tests_new_e2e_bq
branch
from
e0f7676 to
78da804
Compare
bharatgulati
added
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.