Bigtable E2E coverage as per ITN class.#1385
Bigtable E2E coverage as per ITN class.#1385sahusanket merged 1 commit intodata-integrations:developfrom
Conversation
bharatgulati
added
build
AnkitCLI
force-pushed
the
BigTableE2E
branch
2 times, most recently
from
0acb4ce to
7a1f024
Compare
AnkitCLI
force-pushed
the
BigTableE2E
branch
2 times, most recently
from
1a3b957 to
17c5f9d
Compare
| try { | ||
| Instance instance = adminClient.createInstance(createInstanceRequest); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Please add a logger, and use LOG.error("Error occuring while creating big table instance",e);
There was a problem hiding this comment.
For reference : see class GCSValidationHelper
|
|
||
| List<String> families = ImmutableList.of("cf1", "cf2"); | ||
| if (sourceTable != null) { | ||
| createTable(connection, |
There was a problem hiding this comment.
NIT : no need of indentation, keep in single line
| sourceTable, families); | ||
| } | ||
| if (sinkTable != null) { | ||
| createTable(connection, |
There was a problem hiding this comment.
NIT : no need of indentation, keep in single line
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ |
There was a problem hiding this comment.
NIT : Correct indentation ( check other files )
| @BigTable @BIGTABLE_SOURCE_TEST | ||
| Feature: BigTable source - Verification of BigTable to BigTable Successful Data Transfer | ||
|
|
||
| @BIGTABLE_SINK_TEST |
There was a problem hiding this comment.
I see the logic that before every test begins with deleting instance.
But CLEAN UP should happen after a test is completed.
Please change the logic to add clean up in the AFTER bock.
A test should not have any remaining from a previous run test.
There was a problem hiding this comment.
I did not get this.
What i mean is The SOURCE TABLE and the SINK TABLE should be deleted using AFTER block.
There was a problem hiding this comment.
yes they are get delete after the scenarios completes.
| Feature: BigTable source - Verification of BigTable to BigTable Successful Data Transfer | ||
|
|
||
| @BIGTABLE_SINK_TEST | ||
| Scenario: To verify data is getting transferred from BigTable source table to BigTable sink table |
There was a problem hiding this comment.
How is this test different from 3rd test i.e. "To verify data is getting transferred from BigTable source table to NON existing BigTable sink" ?
There was a problem hiding this comment.
the difference between 1 and 3 is in first we are validating that source table is here by using validate plugin step line but in 3 we are not validating that and we are simply going as non existing tab.
| */ | ||
| public class TestSetupHooks { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(TestSetupHooks.class); |
There was a problem hiding this comment.
NIT : refactor logger to LOG ( static final vars are usually written in CAPs )
| Then Validate data transferred to existing target bigtable table with data of source bigtable table | ||
|
|
||
| @BIGTABLE_SOURCE_TEST @BIGTABLE_SINK_TEST | ||
| Scenario: To verify data is getting transferred from not existing BigTable source table to BigTable sink table |
There was a problem hiding this comment.
Let's change the name to un-validated big table source (discussed offline)
AnkitCLI
force-pushed
the
BigTableE2E
branch
2 times, most recently
from
6c14831 to
3810bb8
Compare
4 participants
No description provided.