[PLUGIN-1563] Add support in BQ Source to read JSON columns#1391
Merged
itsankit-google merged 1 commit intodata-integrations:developfrom Apr 19, 2024
Merged
Conversation
psainics
force-pushed
the
patch/bq-source-json-support
branch
from
d68eb2c to
f6cd4bf
Compare
psainics
force-pushed
the
patch/bq-source-json-support
branch
2 times, most recently
from
8728d58 to
814b86a
Compare
psainics
force-pushed
the
patch/bq-source-json-support
branch
2 times, most recently
from
c36dcc6 to
b75bbcd
Compare
Comment on lines
+162
to
+164
| LegacySQLTypeName typeJson = LegacySQLTypeName.valueOf("JSON"); | ||
| // Treat JSON as string | ||
| StandardSQLTypeName standardType = type.equals(typeJson) ? StandardSQLTypeName.STRING : type.getStandardType(); |
Contributor
There was a problem hiding this comment.
nit: this looks more readable
StandardSQLTypeName standardType = LegacySQLTypeName.valueOf("JSON").equals(type) ?
StandardSQLTypeName.STRING : type.getStandardType();
b75bbcd to
47001d9
Compare
psainics
force-pushed
the
patch/bq-source-json-support
branch
from
47001d9 to
8cfba20
Compare
itsankit-google
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support in BQ Source to read JSON columns
Jira : PLUGIN-1563
Description
This PR adds the ability to read columns with JSON columns.
We treat Json type as a string.
UI Field
Docs
Code change
BigQueryUtil.javaUnit Tests
BigQueryUtilTest.javatestConvertFieldTypeJsonToString