E2E test coverage for BQMT#1392
Merged
samdgupi merged 1 commit intodata-integrations:developfrom Apr 12, 2024
Merged
Conversation
AnkitCLI
force-pushed
the
bqmt_e2e-ITN
branch
2 times, most recently
from
c677195 to
9966e85
Compare
samdgupi
reviewed
Apr 8, 2024
AnkitCLI
force-pushed
the
bqmt_e2e-ITN
branch
2 times, most recently
from
4bb2c3b to
a9498bb
Compare
samdgupi
suggested changes
Apr 10, 2024
samdgupi
reviewed
Apr 10, 2024
| } | ||
| // Fetch data from the target BigQuery table | ||
| List<Object> bigQueryRows2 = new ArrayList<>(); | ||
| getBigQueryTableData(targetTable, bigQueryRows2); |
Contributor
There was a problem hiding this comment.
nit: Use bigQueryRowsTarget and bigQueryRowsSource
samdgupi
reviewed
Apr 10, 2024
| getBigQueryTableData(targetTable, bigQueryRows2); | ||
| List<JsonObject> bigQueryResponse2 = new ArrayList<>(); | ||
| for (Object row : bigQueryRows2) { | ||
| JsonObject jsonData = gson.fromJson(String.valueOf(row), JsonObject.class); |
Contributor
There was a problem hiding this comment.
nit: You can create a proper class here to deserialize.
Contributor
Author
There was a problem hiding this comment.
we are using these method from common code that we are using for all the plugins to deserialize data from bq.
samdgupi
reviewed
Apr 10, 2024
| result.iterateAll().forEach(value -> bigQueryRows.add(value.get(0).getValue())); | ||
| } | ||
|
|
||
| private static boolean compareBigQueryDataAndBQMT(List<JsonObject> bigQueryResponse, List<JsonObject> bqmtData) |
Contributor
There was a problem hiding this comment.
A better way to compare is to write concrete classes and use equals method.
Contributor
Author
There was a problem hiding this comment.
same comment as above.
samdgupi
previously approved these changes
Apr 10, 2024
AnkitCLI
force-pushed
the
bqmt_e2e-ITN
branch
2 times, most recently
from
31dc28a to
2216993
Compare
samdgupi
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains ITN tests which are covered as e2e tests for BigQueryMultiTable.
Link=https://github.com/cdapio/cdap-integration-tests/blob/release/6.8/integration-test-remote/src/test/java/io/cdap/cdap/app/etl/gcp/GoogleBigQueryMultiSinkTest.java