Skip to content

[PLUGIN-1318] Added ArgumentsColumnsList Exists Validation, Fix PlaceHolder Key#1396

Merged
psainics merged 1 commit intodata-integrations:developfrom
cloudsufi:plugin-1318
Apr 22, 2024
Merged

[PLUGIN-1318] Added ArgumentsColumnsList Exists Validation, Fix PlaceHolder Key#1396
psainics merged 1 commit intodata-integrations:developfrom
cloudsufi:plugin-1318

Conversation

@psainics
Copy link
Copy Markdown
Contributor

@psainics psainics commented Apr 16, 2024 •
edited
Loading

Added ArgumentsColumnsList Exists Validation, Fix PlaceHolder Key

Jira : PLUGIN-1318

Description

This PR adds validation for Argument Columns field.

  • Checks if passed value is present in source table as a column.
  • Fixes the placeholder key.

image

UI Field

  • Modified BigQueryArgumentSetter-action.json

Docs

  • No Changes made to docs.

Code change

  • Modified BigQueryArgumentSetterConfig.java

Unit Tests

Added new unit tests

  • testCheckIfArgumentsColumnsListExistsInSourceMatchOne
  • testCheckIfArgumentsColumnsListExistsInSourceMatchSome
  • testCheckIfArgumentsColumnsListExistsInSourceFailedMatchOne
  • testCheckIfArgumentsColumnsListExistsInSourceFailedMatchSome

image

@psainics psainics added the build Trigger unit test build label Apr 16, 2024
itsankit-google
itsankit-google reviewed Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

itsankit-google
itsankit-google reviewed Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsankit-google itsankit-google left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the changes tested during pipeline validation? Do we also need to do collector.getOrThrowException()?

@psainics
Copy link
Copy Markdown
Contributor Author

psainics commented Apr 22, 2024

Added new unit tests

  • testCheckIfArgumentsColumnsListExistsInSourceMatchOne
  • testCheckIfArgumentsColumnsListExistsInSourceMatchSome
  • testCheckIfArgumentsColumnsListExistsInSourceFailedMatchOne
  • testCheckIfArgumentsColumnsListExistsInSourceFailedMatchSome

image

  • This is tested during validation , we see error as expected !

image

@itsankit-google
Copy link
Copy Markdown
Contributor

itsankit-google commented Apr 22, 2024

Please raise a cherry-pick in release/0.23.

@psainics psainics merged commit ef32134 into data-integrations:develop Apr 22, 2024
@psainics psainics mentioned this pull request Apr 22, 2024
Merged
@psainics psainics deleted the plugin-1318 branch February 13, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

Assignees

No one assigned

Labels

build Trigger unit test build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psainics @itsankit-google