Skip to content

[PLUGIN-1866] Code Cleanup BigQueryUtil #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psainics merged 1 commit into from
Mar 10, 2025
Merged

[PLUGIN-1866] Code Cleanup BigQueryUtil #1527

psainics merged 1 commit into from
Mar 10, 2025

Conversation

@psainics
Copy link
Contributor

@psainics psainics commented Mar 5, 2025 •
edited by atlassian bot
Loading

JIRA: PLUGIN-1866

Code Cleanup

  • Remove duplicated functions getBigQueryTable and combine in one.
  • Add read Timeout to function signature in getBigQueryTable
  • Fix Unit Tests

Splitting the code cleanup PR to help Review process of the original PR : #1525 (WIP)

@psainics psainics added the build Trigger unit test build label Mar 5, 2025
@psainics psainics self-assigned this Mar 5, 2025
@psainics psainics changed the title Code Cleanup Code Cleanup BigQueryUtil Mar 5, 2025
@psainics psainics force-pushed the chore/code-cleanup branch from 621f83c to 8ec7517 Compare March 5, 2025 06:09
@psainics psainics marked this pull request as ready for review March 5, 2025 06:21
@psainics psainics requested a review from itsankit-google March 5, 2025 06:40
@psainics psainics mentioned this pull request Mar 5, 2025
Merged
@itsankit-google itsankit-google changed the title Code Cleanup BigQueryUtil [[PLUGIN-1866] Code Cleanup BigQueryUtil Mar 8, 2025
@itsankit-google itsankit-google changed the title [[PLUGIN-1866] Code Cleanup BigQueryUtil [PLUGIN-1866] Code Cleanup BigQueryUtil Mar 8, 2025
@psainics psainics merged commit 2cf8cca into data-integrations:develop Mar 10, 2025
16 checks passed
@psainics psainics deleted the chore/code-cleanup branch March 10, 2025 06:02
@psainics psainics mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

Assignees

@psainics psainics

Labels

build Trigger unit test build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psainics @itsankit-google