Skip to content

[PLUGIN-949] missing key value error msg#79

Merged
rmstar merged 1 commit intodata-integrations:developfrom
sumitnigamcs:PLUGIN-949
Mar 3, 2022
Merged

[PLUGIN-949] missing key value error msg#79
rmstar merged 1 commit intodata-integrations:developfrom
sumitnigamcs:PLUGIN-949

Conversation

@sumitnigamcs
Copy link
Copy Markdown

missing key value error msg

@sumitnigamcs
Copy link
Copy Markdown
Author

@rmstar Please review for PLUGIN-949

Copy link
Copy Markdown
Contributor

@rmstar rmstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please look into adding a unit test?

Comment thread src/main/java/io/cdap/plugin/http/source/common/BaseHttpSourceConfig.java Outdated
Comment thread src/main/java/io/cdap/plugin/http/source/common/BaseHttpSourceConfig.java Outdated
@itsankit-google itsankit-google changed the title missing key value error msg [PLUGIN-949] missing key value error msg Feb 15, 2022
@sumitnigamcs
Copy link
Copy Markdown
Author

sumitnigamcs commented Feb 21, 2022

Can you please look into adding a unit test?

Done @rmstar , Please review.
CC @itsankit-google

Comment thread src/main/java/io/cdap/plugin/http/source/batch/HttpBatchSourceConfig.java Outdated
Comment thread src/test/java/io/cdap/plugin/http/source/common/HttpBatchSourceConfigTest.java Outdated
Comment thread src/test/java/io/cdap/plugin/http/source/common/HttpBatchSourceConfigTest.java Outdated
Comment thread src/test/java/io/cdap/plugin/http/source/common/HttpBatchSourceConfigTest.java Outdated
@sumitnigamcs sumitnigamcs force-pushed the PLUGIN-949 branch 2 times, most recently from b9aeb45 to 940d891 Compare February 23, 2022 10:09
@rmstar rmstar merged commit 09aee0b into data-integrations:develop Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants