Skip to content

[Cherrypick] [PLUGIN-1950] : Log zero records for Table mode and SQL Statement mode and bump up#76

Open
vanshikaagupta22 wants to merge 2 commits into
release/1.4from
PLUGIN-1950_log_zero_records-cherrypick
Open

[Cherrypick] [PLUGIN-1950] : Log zero records for Table mode and SQL Statement mode and bump up#76
vanshikaagupta22 wants to merge 2 commits into
release/1.4from
PLUGIN-1950_log_zero_records-cherrypick

Conversation

@vanshikaagupta22
Copy link
Copy Markdown

@vanshikaagupta22 vanshikaagupta22 commented May 20, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the handling of empty tables by adding logging in DBTableRecordReader and SQLStatementRecordReader when no records are found. Additionally, it makes DBTableSplit.DEFAULT_CLAUSE public and updates MultiTableDBInputFormat to return a default split when result set bounds are null. I have no feedback to provide.

@vikasrathee-cs vikasrathee-cs requested a review from sahusanket May 20, 2026 11:35
@vikasrathee-cs vikasrathee-cs changed the title PLUGIN-1950 : Log zero records for Table mode and SQL Statement mode. [Cherrypick] [PLUGIN-1950] : Log zero records for Table mode and SQL Statement mode and bump up May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants