Fix TaskAttempt Context is null#266
Merged
Vipinofficial11 merged 1 commit intodata-integrations:developfrom Oct 23, 2024
Merged
Fix TaskAttempt Context is null#266Vipinofficial11 merged 1 commit intodata-integrations:developfrom
Vipinofficial11 merged 1 commit intodata-integrations:developfrom
Conversation
Vipinofficial11
force-pushed
the
refactorRecordReaders
branch
from
07b3ff2 to
28e5775
Compare
Vipinofficial11
changed the title
Vipinofficial11
force-pushed
the
refactorRecordReaders
branch
from
28e5775 to
c53bf32
Compare
Contributor
|
Can we validate the WideRecordReader changes in CDAP/CDF today ? |
| InputSplit inputSplit, AuthenticatorCredentials credentials) | ||
| throws IOException, InterruptedException { | ||
| List<Map<String, ?>> fetchedIdList = fetchBulkQueryIds(inputSplit, null); | ||
| List<Map<String, ?>> fetchedIdList = fetchBulkQueryIds(inputSplit, credentials); |
Contributor
There was a problem hiding this comment.
Move the super.initialize call outside fetchBulkQueryIds and call it before the fetchBulkQueryIds call here.
Contributor
Author
There was a problem hiding this comment.
Moved super.initialize before fetchBulkQueryIds and removed paramters from fetchBulkQueryIds as they are not required anymore in the method. [b5c9fe5]
Vipinofficial11
force-pushed
the
refactorRecordReaders
branch
from
b5c9fe5 to
41ccf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include:
SalesforceWideRecordReaderpartitioning logic to address API retrieve limit exceeded errors.