Conversation
Contributor
|
Please add more details in the description, like the issue, RCA, fix, how did we validate etc. |
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
please add JIRA in the PR title.
src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceWideRecordReader.java
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceWideRecordReader.java
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceWideRecordReader.java
Show resolved
Hide resolved
MrRahulSharma
approved these changes
Jun 30, 2025
prince-cs
force-pushed
the
wide-record-reader
branch
from
ef1ba8d to
470cebb
Compare
prince-cs
force-pushed
the
wide-record-reader
branch
from
470cebb to
ed8948b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently records from a single batch are being read in a parallel stream processing and the result is being stored in its entirety. This could lead to out of memory(OOM).
The fix is to ensure that the batches are being read with the help of an iterator rather storing the entire result. Made the changes accordingly to
SalesforceWideRecordReader.javaValidation has been done by making a query of length more than 20k and ensuring the pipeline passes.
JIRA: https://cdap.atlassian.net/browse/PLUGIN-1897