update dependency versions#36
Merged
albertshau merged 1 commit intodevelopfrom Jun 5, 2019
Merged
Conversation
Use non-snapshot versions of CDAP dependencies and update jackson to a newer version.
CuriousVini
reviewed
Jun 5, 2019
CuriousVini
reviewed
Jun 5, 2019
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <!-- version properties --> | ||
| <cdap.version>6.0.0-SNAPSHOT</cdap.version> | ||
| <cdap.version>6.0.0</cdap.version> |
Member
There was a problem hiding this comment.
shouldn't we rely on cdap 6.1.0-SNAPSHOT on develop similar to https://github.com/data-integrations/wrangler/blob/develop/pom.xml#L86?
Contributor
Author
There was a problem hiding this comment.
This plugin declares that it is compatible with 6.x versions of the data-pipeline app, which means this needs to be 6.0.0. If it were to use a new API in 6.1.0-SNAPSHOT and then were to be deployed on a 6.0.x version of CDAP, it would fail.
In general, I think we should change our process for plugins such that we don't update the dependent cdap version unless they need to use some new API, so that they're compatible with as many versions of CDAP as possible.
CuriousVini
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use non-snapshot versions of CDAP dependencies and update jackson
to a newer version.