Skip to content

[PLUGIN-1682] Fixed null output schema#15

Merged
vikasrathee-cs merged 1 commit intodata-integrations:developfrom
cloudsufi:csm2007
Sep 20, 2023
Merged

[PLUGIN-1682] Fixed null output schema#15
vikasrathee-cs merged 1 commit intodata-integrations:developfrom
cloudsufi:csm2007

Conversation

@psainics
Copy link
Copy Markdown

@psainics psainics commented Sep 18, 2023

Jira Link

Issue

When user is using macro as any connection properties and set schema manually, it is getting validated properly and pipeline is getting formed using wrangler as transform with proper input schema.
But during pipeline run, outputschema in pipelineconfigurer for snowflake is set to null in case of macros and that is causing null pointer exception mentioned in the jira ticket.

BugFix

When macros are enabled and schema cannot be fetched, we are fetching config.schema and setting it as outputschema.

Unit Test

  • 2 Unit Test are added to verify the logic
  • When user has set the schema and when the user has not
  1. testGetSchemaWhenMacroIsEnabled
  2. testGetSchemaWhenMacroIsEnabledSchemaIsNull

image

@psainics psainics changed the title Fixed null output schema [PLUGIN-1682] Fixed null output schema Sep 18, 2023
@MrRahulSharma MrRahulSharma self-assigned this Sep 19, 2023
@MrRahulSharma
Copy link
Copy Markdown
Contributor

Please update the description:

  1. JIRA link
  2. RCA for the issue, and explanation for the fix.

@vikasrathee-cs
Copy link
Copy Markdown
Contributor

Please update the description:

  1. JIRA link
  2. RCA for the issue, and explanation for the fix.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants